Unverified Commit 024f170b authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!12609 blk_iocost: fix more out of bound shifts 

Merge Pull Request from: @ci-robot 
 
PR sync from: Zheng Qixing <zhengqixing@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/QNT7WDKFJEXH4JFXTPX2VSUX3ITMHQ7O/ 
 
https://gitee.com/src-openeuler/kernel/issues/IAYRCW 
 
Link:https://gitee.com/openeuler/kernel/pulls/12609

 

Reviewed-by: default avatarYu Kuai <yukuai3@huawei.com>
Reviewed-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parents 7936c422 f15e9bda

block/blk-iocost.c

+5 −3
Original line number Diff line number Diff line
@@ -2038,7 +2038,7 @@ static void ioc_forgive_debts(struct ioc *ioc, u64 usage_us_sum, int nr_debtors, 
			      struct ioc_now *now)

{

	struct ioc_gq *iocg;

	u64 dur, usage_pct, nr_cycles;

	u64 dur, usage_pct, nr_cycles, nr_cycles_shift;



	/* if no debtor, reset the cycle */

	if (!nr_debtors) {
@@ -2100,10 +2100,12 @@ static void ioc_forgive_debts(struct ioc *ioc, u64 usage_us_sum, int nr_debtors, 
		old_debt = iocg->abs_vdebt;

		old_delay = iocg->delay;



		nr_cycles_shift = min_t(u64, nr_cycles, BITS_PER_LONG - 1);

		if (iocg->abs_vdebt)

			iocg->abs_vdebt = iocg->abs_vdebt >> nr_cycles ?: 1;

			iocg->abs_vdebt = iocg->abs_vdebt >> nr_cycles_shift ?: 1;



		if (iocg->delay)

			iocg->delay = iocg->delay >> nr_cycles ?: 1;

			iocg->delay = iocg->delay >> nr_cycles_shift ?: 1;



		iocg_kick_waitq(iocg, true, now);