Commit 02461d93 authored by Martin Blumenstingl's avatar Martin Blumenstingl Committed by Kalle Valo
Browse files

wifi: rtw88: main: Reserve 8 bytes of extra TX headroom for SDIO cards 



For SDIO host controllers with DMA support the TX buffer physical memory
address need to be aligned at an 8-byte boundary. Reserve 8 bytes of
extra TX headroom so we can align the data without re-allocating the
transmit buffer.

While here, also remove the TODO comment regarding extra headroom for
USB and SDIO. For SDIO the extra headroom is now handled and for USB it
was not needed so far.

Reviewed-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: default avatarKalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230405200729.632435-6-martin.blumenstingl@googlemail.com
parent a5d25f9f

drivers/net/wireless/realtek/rtw88/main.c

+3 −1
Original line number Diff line number Diff line
@@ -2163,9 +2163,11 @@ int rtw_register_hw(struct rtw_dev *rtwdev, struct ieee80211_hw *hw) 
	int max_tx_headroom = 0;

	int ret;



	/* TODO: USB & SDIO may need extra room? */

	max_tx_headroom = rtwdev->chip->tx_pkt_desc_sz;



	if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_SDIO)

		max_tx_headroom += RTW_SDIO_DATA_PTR_ALIGN;



	hw->extra_tx_headroom = max_tx_headroom;

	hw->queues = IEEE80211_NUM_ACS;

	hw->txq_data_size = sizeof(struct rtw_txq);