Commit 022fe6bc authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Rafael J. Wysocki
Browse files

device property: Drop 'test' prefix in parameters of fwnode_is_ancestor_of() 



The part 'is' in the function name implies the test against something.
Drop unnecessary 'test' prefix in the fwnode_is_ancestor_of() parameters.

No functional change intended.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 87ffea09

drivers/base/property.c

+9 −11
Original line number Diff line number Diff line
@@ -656,28 +656,26 @@ struct fwnode_handle *fwnode_get_nth_parent(struct fwnode_handle *fwnode, 
EXPORT_SYMBOL_GPL(fwnode_get_nth_parent);



/**

 * fwnode_is_ancestor_of - Test if @test_ancestor is ancestor of @test_child

 * @test_ancestor: Firmware which is tested for being an ancestor

 * @test_child: Firmware which is tested for being the child

 * fwnode_is_ancestor_of - Test if @ancestor is ancestor of @child

 * @ancestor: Firmware which is tested for being an ancestor

 * @child: Firmware which is tested for being the child

 *

 * A node is considered an ancestor of itself too.

 *

 * Returns true if @test_ancestor is an ancestor of @test_child.

 * Otherwise, returns false.

 * Returns true if @ancestor is an ancestor of @child. Otherwise, returns false.

 */

bool fwnode_is_ancestor_of(struct fwnode_handle *test_ancestor,

				  struct fwnode_handle *test_child)

bool fwnode_is_ancestor_of(struct fwnode_handle *ancestor, struct fwnode_handle *child)

{

	struct fwnode_handle *parent;



	if (IS_ERR_OR_NULL(test_ancestor))

	if (IS_ERR_OR_NULL(ancestor))

		return false;



	if (test_child == test_ancestor)

	if (child == ancestor)

		return true;



	fwnode_for_each_parent_node(test_child, parent) {

		if (parent == test_ancestor) {

	fwnode_for_each_parent_node(child, parent) {

		if (parent == ancestor) {

			fwnode_handle_put(parent);

			return true;

		}

include/linux/property.h

+1 −2
Original line number Diff line number Diff line
@@ -95,8 +95,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode); 
unsigned int fwnode_count_parents(const struct fwnode_handle *fwn);

struct fwnode_handle *fwnode_get_nth_parent(struct fwnode_handle *fwn,

					    unsigned int depth);

bool fwnode_is_ancestor_of(struct fwnode_handle *test_ancestor,

				  struct fwnode_handle *test_child);

bool fwnode_is_ancestor_of(struct fwnode_handle *ancestor, struct fwnode_handle *child);

struct fwnode_handle *fwnode_get_next_child_node(

	const struct fwnode_handle *fwnode, struct fwnode_handle *child);

struct fwnode_handle *fwnode_get_next_available_child_node(