Unverified Commit 0203471d authored by Daniel Pinto's avatar Daniel Pinto Committed by Konstantin Komarov
Browse files

fs/ntfs3: Fix wrong cast in xattr.c 



cpu_to_be32 and be32_to_cpu respectively return and receive
__be32, change the cast to the correct types.

Fixes the following sparse warnings:
fs/ntfs3/xattr.c:811:48: sparse: sparse: incorrect type in
                         assignment (different base types)
fs/ntfs3/xattr.c:901:34: sparse: sparse: cast to restricted __be32

Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarDaniel Pinto <danielpinto52@gmail.com>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent 197b6b60

fs/ntfs3/xattr.c

+2 −2
Original line number Diff line number Diff line
@@ -780,7 +780,7 @@ static int ntfs_getxattr(const struct xattr_handler *handler, struct dentry *de, 
			err = sizeof(u32);

			*(u32 *)buffer = le32_to_cpu(ni->std_fa);

			if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE))

				*(u32 *)buffer = cpu_to_be32(*(u32 *)buffer);

				*(__be32 *)buffer = cpu_to_be32(*(u32 *)buffer);

		}

		goto out;

	}
@@ -857,7 +857,7 @@ static noinline int ntfs_setxattr(const struct xattr_handler *handler, 
		if (size != sizeof(u32))

			goto out;

		if (!strcmp(name, SYSTEM_NTFS_ATTRIB_BE))

			new_fa = cpu_to_le32(be32_to_cpu(*(u32 *)value));

			new_fa = cpu_to_le32(be32_to_cpu(*(__be32 *)value));

		else

			new_fa = cpu_to_le32(*(u32 *)value);