Commit 0184898d authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Damien Le Moal
Browse files

ata: libata-scsi: fix result type of ata_ioc32() 



While ata_ioc32() returns 'int', its result gets assigned to and compared
with the 'unsigned long' variable 'val' in ata_sas_scsi_ioctl(), its only
caller, which implies a problematic implicit cast (with sign extension).
Fix this by returning 'bool' instead -- the implicit cast then implies
zero extension which is OK.  Note that actually the object code doesn't
change because ata_ioc32() is always inlined -- I can see the expected
code changes with 'noinline'...

Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.

Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent 2b5960a0

drivers/ata/libata-scsi.c

+4 −4
Original line number Diff line number Diff line
@@ -539,13 +539,13 @@ int ata_task_ioctl(struct scsi_device *scsidev, void __user *arg) 
	return rc;

}



static int ata_ioc32(struct ata_port *ap)

static bool ata_ioc32(struct ata_port *ap)

{

	if (ap->flags & ATA_FLAG_PIO_DMA)

		return 1;

		return true;

	if (ap->pflags & ATA_PFLAG_PIO32)

		return 1;

	return 0;

		return true;

	return false;

}



/*