Unverified Commit 0178f1e5 authored by Osama Muhammad's avatar Osama Muhammad Committed by Mark Brown
Browse files

spi-dw-core.c: Fix error checking for debugfs_create_dir 



This patch fixes the error checking in spi-dw-core.c in
debugfs_create_dir. The DebugFS kernel API is developed in
a way that the caller can safely ignore the errors that
occur during the creation of DebugFS nodes.

Signed-off-by: default avatarOsama Muhammad <osmtendev@gmail.com>
Link: https://lore.kernel.org/r/20230520224025.14928-1-osmtendev@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 81ea9a07

drivers/spi/spi-dw-core.c

+2 −6
Original line number Diff line number Diff line
@@ -57,21 +57,18 @@ static const struct debugfs_reg32 dw_spi_dbgfs_regs[] = { 
	DW_SPI_DBGFS_REG("RX_SAMPLE_DLY", DW_SPI_RX_SAMPLE_DLY),

};



static int dw_spi_debugfs_init(struct dw_spi *dws)

static void dw_spi_debugfs_init(struct dw_spi *dws)

{

	char name[32];



	snprintf(name, 32, "dw_spi%d", dws->master->bus_num);

	dws->debugfs = debugfs_create_dir(name, NULL);

	if (!dws->debugfs)

		return -ENOMEM;



	dws->regset.regs = dw_spi_dbgfs_regs;

	dws->regset.nregs = ARRAY_SIZE(dw_spi_dbgfs_regs);

	dws->regset.base = dws->regs;

	debugfs_create_regset32("registers", 0400, dws->debugfs, &dws->regset);



	return 0;

}



static void dw_spi_debugfs_remove(struct dw_spi *dws)
@@ -80,9 +77,8 @@ static void dw_spi_debugfs_remove(struct dw_spi *dws) 
}



#else

static inline int dw_spi_debugfs_init(struct dw_spi *dws)

static inline void dw_spi_debugfs_init(struct dw_spi *dws)

{

	return 0;

}



static inline void dw_spi_debugfs_remove(struct dw_spi *dws)