Commit 01542f65 authored by Kemeng Shi's avatar Kemeng Shi Committed by Jens Axboe
Browse files

blk-mq: correct stale comment of .get_budget 



Commit 88022d72 ("blk-mq: don't handle failure in .get_budget")
remove BLK_STS_RESOURCE return value and we only check if we can get
the budget from .get_budget() now.
Correct stale comment that ".get_budget() returns BLK_STS_NO_RESOURCE"
to ".get_budget() fails to get the budget".

Fixes: 88022d72 ("blk-mq: don't handle failure in .get_budget")
Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 27e8b2bb

block/blk-mq-sched.c

+2 −2
Original line number Diff line number Diff line
@@ -81,7 +81,7 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list) 
/*

 * Only SCSI implements .get_budget and .put_budget, and SCSI restarts

 * its queue by itself in its completion handler, so we don't need to

 * restart queue if .get_budget() returns BLK_STS_NO_RESOURCE.

 * restart queue if .get_budget() fails to get the budget.

 *

 * Returns -EAGAIN if hctx->dispatch was found non-empty and run_work has to

 * be run again.  This is necessary to avoid starving flushes.
@@ -209,7 +209,7 @@ static struct blk_mq_ctx *blk_mq_next_ctx(struct blk_mq_hw_ctx *hctx, 
/*

 * Only SCSI implements .get_budget and .put_budget, and SCSI restarts

 * its queue by itself in its completion handler, so we don't need to

 * restart queue if .get_budget() returns BLK_STS_NO_RESOURCE.

 * restart queue if .get_budget() fails to get the budget.

 *

 * Returns -EAGAIN if hctx->dispatch was found non-empty and run_work has to

 * be run again.  This is necessary to avoid starving flushes.