Commit 01414f88 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Kalle Valo
Browse files

libertas: avoid -Wempty-body warning 



Building without mesh supports shows a couple of warnings with
'make W=1':

drivers/net/wireless/marvell/libertas/main.c: In function 'lbs_start_card':
drivers/net/wireless/marvell/libertas/main.c:1068:37: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
 1068 |                 lbs_start_mesh(priv);

Change the macros to use the usual "do { } while (0)" instead to shut up
the warnings and make the code a litte more robust.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210322104343.948660-4-arnd@kernel.org
parent 431eb49e

drivers/net/wireless/marvell/libertas/mesh.h

+6 −6
Original line number Diff line number Diff line
@@ -60,13 +60,13 @@ void lbs_mesh_ethtool_get_strings(struct net_device *dev, 


#else



#define lbs_init_mesh(priv)

#define lbs_deinit_mesh(priv)

#define lbs_start_mesh(priv)

#define lbs_add_mesh(priv)

#define lbs_remove_mesh(priv)

#define lbs_init_mesh(priv)	do { } while (0)

#define lbs_deinit_mesh(priv)	do { } while (0)

#define lbs_start_mesh(priv)	do { } while (0)

#define lbs_add_mesh(priv)	do { } while (0)

#define lbs_remove_mesh(priv)	do { } while (0)

#define lbs_mesh_set_dev(priv, dev, rxpd) (dev)

#define lbs_mesh_set_txpd(priv, dev, txpd)

#define lbs_mesh_set_txpd(priv, dev, txpd) do { } while (0)

#define lbs_mesh_set_channel(priv, channel) (0)

#define lbs_mesh_activated(priv) (false)