Commit 011881b8 authored by 蒋家盛's avatar 蒋家盛 Committed by Hans de Goede
Browse files

platform/x86: barco-p50-gpio: Add check for platform_driver_register 



As platform_driver_register() could fail, it should be better
to deal with the return value in order to maintain the code
consisitency.

Fixes: 86af1d02 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
Signed-off-by: default avatarJiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: default avatarPeter Korsgaard <peter.korsgaard@barco.com>
Link: https://lore.kernel.org/r/20220526090345.1444172-1-jiasheng@iscas.ac.cn


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 552f3b80

drivers/platform/x86/barco-p50-gpio.c

+4 −1
Original line number Diff line number Diff line
@@ -405,11 +405,14 @@ MODULE_DEVICE_TABLE(dmi, dmi_ids); 
static int __init p50_module_init(void)

{

	struct resource res = DEFINE_RES_IO(P50_GPIO_IO_PORT_BASE, P50_PORT_CMD + 1);

	int ret;



	if (!dmi_first_match(dmi_ids))

		return -ENODEV;



	platform_driver_register(&p50_gpio_driver);

	ret = platform_driver_register(&p50_gpio_driver);

	if (ret)

		return ret;



	gpio_pdev = platform_device_register_simple(DRIVER_NAME, PLATFORM_DEVID_NONE, &res, 1);

	if (IS_ERR(gpio_pdev)) {