Commit 01142791 authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Catalin Marinas
Browse files

arm64: mm: avoid writable executable mappings in kexec/hibernate code 



The temporary mappings of the low-level kexec and hibernate helpers are
created with both writable and executable attributes, which is not
necessary here, and generally best avoided. So use read-only, executable
attributes instead.

Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
Acked-by: default avatarMark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20220429131347.3621090-3-ardb@kernel.org


Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 6ee3cf6a

arch/arm64/mm/trans_pgd.c

+1 −1
Original line number Diff line number Diff line
@@ -238,7 +238,7 @@ int trans_pgd_idmap_page(struct trans_pgd_info *info, phys_addr_t *trans_ttbr0, 
	int this_level, index, level_lsb, level_msb;



	dst_addr &= PAGE_MASK;

	prev_level_entry = pte_val(pfn_pte(pfn, PAGE_KERNEL_EXEC));

	prev_level_entry = pte_val(pfn_pte(pfn, PAGE_KERNEL_ROX));



	for (this_level = 3; this_level >= 0; this_level--) {

		levels[this_level] = trans_alloc(info);