Commit 01097139 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Jason Gunthorpe
Browse files

RDMA: Use default_groups in kobj_type 

There are currently 2 ways to create a set of sysfs files for a kobj_type,
through the default_attrs field, and the default_groups field.  Move the
IB code to use default_groups field which has been the preferred way since
commit aa30f47c ("kobject: Add support for default attribute groups to
kobj_type") so that we can soon get rid of the obsolete default_attrs
field.

Link: https://lore.kernel.org/r/20220103152259.531034-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent a7ad9dde

drivers/infiniband/core/sysfs.c

+2 −1
Original line number Diff line number Diff line
@@ -433,6 +433,7 @@ static struct attribute *port_default_attrs[] = { 
	&ib_port_attr_link_layer.attr,

	NULL

};

ATTRIBUTE_GROUPS(port_default);



static ssize_t print_ndev(const struct ib_gid_attr *gid_attr, char *buf)

{
@@ -774,7 +775,7 @@ static void ib_port_gid_attr_release(struct kobject *kobj) 
static struct kobj_type port_type = {

	.release       = ib_port_release,

	.sysfs_ops     = &port_sysfs_ops,

	.default_attrs = port_default_attrs

	.default_groups = port_default_groups,

};



static struct kobj_type gid_attr_type = {

drivers/infiniband/hw/usnic/usnic_ib_sysfs.c

+2 −1
Original line number Diff line number Diff line
@@ -243,10 +243,11 @@ static struct attribute *usnic_ib_qpn_default_attrs[] = { 
	&qpn_attr_summary.attr,

	NULL

};

ATTRIBUTE_GROUPS(usnic_ib_qpn_default);



static struct kobj_type usnic_ib_qpn_type = {

	.sysfs_ops = &usnic_ib_qpn_sysfs_ops,

	.default_attrs = usnic_ib_qpn_default_attrs

	.default_groups = usnic_ib_qpn_default_groups,

};



int usnic_ib_sysfs_register_usdev(struct usnic_ib_dev *us_ibdev)