Commit 01085e24 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Greg Kroah-Hartman
Browse files

devtmpfs: actually reclaim some init memory 



Currently gcc seems to inline devtmpfs_setup() into devtmpfsd(), so
its memory footprint isn't reclaimed as intended. Mark it noinline to
make sure it gets put in .init.text.

While here, setup_done can also be put in .init.data: After complete()
releases the internal spinlock, the completion object is never touched
again by that thread, and the waiting thread doesn't proceed until it
observes ->done while holding that spinlock.

This is now the same pattern as for kthreadd_done in init/main.c:
complete() is done in a __ref function, while the corresponding
wait_for_completion() is in an __init function.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Link: https://lore.kernel.org/r/20210312103027.2701413-2-linux@rasmusvillemoes.dk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 38f087de

drivers/base/devtmpfs.c

+2 −2
Original line number Diff line number Diff line
@@ -371,7 +371,7 @@ int __init devtmpfs_mount(void) 
	return err;

}



static DECLARE_COMPLETION(setup_done);

static __initdata DECLARE_COMPLETION(setup_done);



static int handle(const char *name, umode_t mode, kuid_t uid, kgid_t gid,

		  struct device *dev)
@@ -405,7 +405,7 @@ static void __noreturn devtmpfs_work_loop(void) 
	}

}



static int __init devtmpfs_setup(void *p)

static noinline int __init devtmpfs_setup(void *p)

{

	int err;