Commit 010764b8 authored by Dan Carpenter's avatar Dan Carpenter Committed by Andy Shevchenko
Browse files

tools/power/x86/intel-speed-select: Fix a read overflow in isst_set_tdp_level_msr() 



The isst_send_msr_command() function will read 8 bytes but we are
passing an address to an int (4 bytes) so it results in a read overflow.

Fixes: 3fb4f7cd ("tools/power/x86: A tool to validate Intel Speed Select commands")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 0ecee9e3

tools/power/x86/intel-speed-select/isst-core.c

+2 −2
Original line number Diff line number Diff line
@@ -190,6 +190,7 @@ int isst_get_get_trl(int cpu, int level, int avx_level, int *trl) 


int isst_set_tdp_level_msr(int cpu, int tdp_level)

{

	unsigned long long level = tdp_level;

	int ret;



	debug_printf("cpu: tdp_level via MSR %d\n", cpu, tdp_level);
@@ -202,8 +203,7 @@ int isst_set_tdp_level_msr(int cpu, int tdp_level) 
	if (tdp_level > 2)

		return -1; /* invalid value */



	ret = isst_send_msr_command(cpu, 0x64b, 1,

				    (unsigned long long *)&tdp_level);

	ret = isst_send_msr_command(cpu, 0x64b, 1, &level);

	if (ret)

		return ret;