Commit 00f4bc51 authored by William Breathitt Gray's avatar William Breathitt Gray
Browse files

counter: 104-quad-8: Fix Synapse action reported for Index signals 

Signal 16 and higher represent the device's Index lines. The
priv->preset_enable array holds the device configuration for these Index
lines. The preset_enable configuration is active low on the device, so
invert the conditional check in quad8_action_read() to properly handle
the logical state of preset_enable.

Fixes: f1d8a071 ("counter: 104-quad-8: Add Generic Counter interface support")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230316203426.224745-1-william.gray@linaro.org/


Signed-off-by: default avatarWilliam Breathitt Gray <william.gray@linaro.org>
parent 4aa3b75c

drivers/counter/104-quad-8.c

+1 −1
Original line number Diff line number Diff line
@@ -368,7 +368,7 @@ static int quad8_action_read(struct counter_device *counter, 


	/* Handle Index signals */

	if (synapse->signal->id >= 16) {

		if (priv->preset_enable[count->id])

		if (!priv->preset_enable[count->id])

			*action = COUNTER_SYNAPSE_ACTION_RISING_EDGE;

		else

			*action = COUNTER_SYNAPSE_ACTION_NONE;