Unverified Commit 00ec947c authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/connector: Mention the cleanup after drm_connector_init 



Unlike encoders and CRTCs, the drm_connector_init() and
drm_connector_init_with_ddc() don't mention how the cleanup is supposed to
be done. Let's add it.

Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220711173939.1132294-6-maxime@cerno.tech
parent d71d8a4b

drivers/gpu/drm/drm_connector.c

+8 −0
Original line number Diff line number Diff line
@@ -224,6 +224,10 @@ void drm_connector_free_work_fn(struct work_struct *work) 
 * Initialises a preallocated connector. Connectors should be

 * subclassed as part of driver connector objects.

 *

 * At driver unload time the driver's &drm_connector_funcs.destroy hook

 * should call drm_connector_cleanup() and free the connector structure.

 * The connector structure should not be allocated with devm_kzalloc().

 *

 * Returns:

 * Zero on success, error code on failure.

 */
@@ -347,6 +351,10 @@ EXPORT_SYMBOL(drm_connector_init); 
 * Initialises a preallocated connector. Connectors should be

 * subclassed as part of driver connector objects.

 *

 * At driver unload time the driver's &drm_connector_funcs.destroy hook

 * should call drm_connector_cleanup() and free the connector structure.

 * The connector structure should not be allocated with devm_kzalloc().

 *

 * Ensures that the ddc field of the connector is correctly set.

 *

 * Returns: