Commit 00c9d563 authored by wuchi's avatar wuchi Committed by Andrew Morton
Browse files

lib/error-inject: convert to DEFINE_SEQ_ATTRIBUTE 

Use DEFINE_SEQ_ATTRIBUTE helper macro to simplify the code.

Link: https://lkml.kernel.org/r/20220612052015.23283-1-wuchi.zero@gmail.com


Signed-off-by: default avatarwuchi <wuchi.zero@gmail.com>
Cc: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Cc: Martin KaFai Lau <kafai@fb.com>
Cc: Song Liu <songliubraving@fb.com>
Cc: Yonghong Song <yhs@fb.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: KP Singh <kpsingh@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent f858e23a

lib/error-inject.c

+3 −13
Original line number Diff line number Diff line
@@ -197,24 +197,14 @@ static int ei_seq_show(struct seq_file *m, void *v) 
	return 0;

}



static const struct seq_operations ei_seq_ops = {

static const struct seq_operations ei_sops = {

	.start = ei_seq_start,

	.next  = ei_seq_next,

	.stop  = ei_seq_stop,

	.show  = ei_seq_show,

};



static int ei_open(struct inode *inode, struct file *filp)

{

	return seq_open(filp, &ei_seq_ops);

}



static const struct file_operations debugfs_ei_ops = {

	.open           = ei_open,

	.read           = seq_read,

	.llseek         = seq_lseek,

	.release        = seq_release,

};

DEFINE_SEQ_ATTRIBUTE(ei);



static int __init ei_debugfs_init(void)

{
@@ -224,7 +214,7 @@ static int __init ei_debugfs_init(void) 
	if (!dir)

		return -ENOMEM;



	file = debugfs_create_file("list", 0444, dir, NULL, &debugfs_ei_ops);

	file = debugfs_create_file("list", 0444, dir, NULL, &ei_fops);

	if (!file) {

		debugfs_remove(dir);

		return -ENOMEM;