Commit 00927931 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: fix fdinfo sqe offsets calculation 



Only with the big sqe feature they take 128 bytes per entry, but we
unconditionally advance by 128B. Fix it by using sq_shift.

Fixes: 3b8fdd1d ("io_uring/fdinfo: fix sqe dumping for IORING_SETUP_SQE128")
Reported-and-tested-by: default avatar <syzbot+e5198737e8a2d23d958c@syzkaller.appspotmail.com>
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/8b41287cb75d5efb8fcb5cccde845ddbbadd8372.1665449983.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent c86416c6

io_uring/fdinfo.c

+1 −1
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ static __cold void __io_uring_show_fdinfo(struct io_ring_ctx *ctx, 
		sq_idx = READ_ONCE(ctx->sq_array[entry & sq_mask]);

		if (sq_idx > sq_mask)

			continue;

		sqe = &ctx->sq_sqes[sq_idx << 1];

		sqe = &ctx->sq_sqes[sq_idx << sq_shift];

		seq_printf(m, "%5u: opcode:%s, fd:%d, flags:%x, off:%llu, "

			      "addr:0x%llx, rw_flags:0x%x, buf_index:%d "

			      "user_data:%llu",