Commit 00749469 authored by Dinghao Liu's avatar Dinghao Liu Committed by Takashi Iwai
Browse files

ALSA: intel8x0: Fix missing check in snd_intel8x0m_create 



When device_type == DEVICE_ALI, we should also check the return
value of pci_iomap() to avoid potential null pointer dereference.

Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20210131100916.7915-1-dinghao.liu@zju.edu.cn


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 0417fada

sound/pci/intel8x0m.c

+2 −1
Original line number Diff line number Diff line
@@ -1129,13 +1129,14 @@ static int snd_intel8x0m_create(struct snd_card *card, 
		chip->bmaddr = pci_iomap(pci, 3, 0);

	else

		chip->bmaddr = pci_iomap(pci, 1, 0);



port_inited:

	if (!chip->bmaddr) {

		dev_err(card->dev, "Controller space ioremap problem\n");

		snd_intel8x0m_free(chip);

		return -EIO;

	}



 port_inited:

	/* initialize offsets */

	chip->bdbars_count = 2;

	tbl = intel_regs;