Commit 006750b4 authored by Ekaterina Orlova's avatar Ekaterina Orlova Committed by sanglipeng
Browse files

ASN.1: Fix check for strdup() success 

stable inclusion
from stable-v5.10.179
commit 0367bf3f4a4eb6691e18194beb5792843aecced9
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I8C809

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=0367bf3f4a4eb6691e18194beb5792843aecced9



--------------------------------

commit 5a43001c upstream.

It seems there is a misprint in the check of strdup() return code that
can lead to NULL pointer dereference.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 4520c6a4 ("X.509: Add simple ASN.1 grammar compiler")
Signed-off-by: default avatarEkaterina Orlova <vorobushek.ok@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: keyrings@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org
Link: https://lore.kernel.org/r/20230315172130.140-1-vorobushek.ok@gmail.com/


Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 0bdb38a8

scripts/asn1_compiler.c

+1 −1
Original line number Diff line number Diff line
@@ -625,7 +625,7 @@ int main(int argc, char **argv) 
	p = strrchr(argv[1], '/');

	p = p ? p + 1 : argv[1];

	grammar_name = strdup(p);

	if (!p) {

	if (!grammar_name) {

		perror(NULL);

		exit(1);

	}