Commit 0056a7f0 authored by Fenghua Yu's avatar Fenghua Yu Committed by Vinod Koul
Browse files

dmaengine: idxd: Allow ATS disable update only for configurable devices 



ATS disable status in a WQ is read-only if the device is not configurable.
This change ensures that the ATS disable attribute can be modified via
sysfs only on configurable devices.

Fixes: 92de5fa2 ("dmaengine: idxd: add ATS disable knob for work queues")
Signed-off-by: default avatarFenghua Yu <fenghua.yu@intel.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20230811012635.535413-1-fenghua.yu@intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 84b798fe

drivers/dma/idxd/sysfs.c

+4 −0
Original line number Diff line number Diff line
@@ -1088,12 +1088,16 @@ static ssize_t wq_ats_disable_store(struct device *dev, struct device_attribute 
				    const char *buf, size_t count)

{

	struct idxd_wq *wq = confdev_to_wq(dev);

	struct idxd_device *idxd = wq->idxd;

	bool ats_dis;

	int rc;



	if (wq->state != IDXD_WQ_DISABLED)

		return -EPERM;



	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))

		return -EPERM;



	rc = kstrtobool(buf, &ats_dis);

	if (rc < 0)

		return rc;