Commit 0023b28b authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Rafael J. Wysocki
Browse files

ACPI: sysfs: Refactor param_get_trace_state() to drop dead code 



The param_get_trace_state() has a few dead code issues:
 - 'return 0;' is never reachable
 - a few 'else' keywords are redundant

Refactor param_get_trace_state() to drop dead code.

Note, leave one 'else' in order to have the best readability.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent b272c059

drivers/acpi/sysfs.c

+6 −10
Original line number Diff line number Diff line
@@ -255,16 +255,12 @@ static int param_get_trace_state(char *buffer, const struct kernel_param *kp) 
{

	if (!(acpi_gbl_trace_flags & ACPI_TRACE_ENABLED))

		return sprintf(buffer, "disable\n");

	else {

		if (acpi_gbl_trace_method_name) {

	if (!acpi_gbl_trace_method_name)

		return sprintf(buffer, "enable\n");

	if (acpi_gbl_trace_flags & ACPI_TRACE_ONESHOT)

		return sprintf(buffer, "method-once\n");

	else

		return sprintf(buffer, "method\n");

		} else

			return sprintf(buffer, "enable\n");

	}

	return 0;

}



module_param_call(trace_state, param_set_trace_state, param_get_trace_state,